fix dialog and drawer header; fixes #1209 (#1213)

This commit is contained in:
Cory LaViska
2025-07-22 13:57:07 -04:00
committed by GitHub
parent 9a7b258108
commit 310f7a8c5d
3 changed files with 6 additions and 6 deletions

View File

@@ -14,6 +14,10 @@ Components with the <wa-badge variant="warning">Experimental</wa-badge> badge sh
- Added the `icon-position` attribute to `<wa-details>` [discuss:1099]
### Bug Fixes and Improvements {data-no-outline}
- Fixed a bug in `<wa-dialog>` and `<wa-drawer>` that prevented the header from showing when the label was missing [issue:1209]
## 3.0.0-beta.3
### New Features {data-no-outline}

View File

@@ -205,9 +205,7 @@ export default class WaDialog extends WebAwesomeElement {
}
render() {
const hasHeader =
!this.withoutHeader &&
(this.label.length > 0 || this.hasSlotController.test('label') || this.hasSlotController.test('header-actions'));
const hasHeader = !this.withoutHeader;
const hasFooter = this.hasSlotController.test('footer');
return html`

View File

@@ -218,9 +218,7 @@ export default class WaDrawer extends WebAwesomeElement {
}
render() {
const hasHeader =
!this.withoutHeader &&
(this.label.length > 0 || this.hasSlotController.test('label') || this.hasSlotController.test('header-actions'));
const hasHeader = !this.withoutHeader;
const hasFooter = this.hasSlotController.test('footer');
return html`