js/webawesome
1
0
Fork 0
mirror of https://github.com/shoelace-style/webawesome.git synced 2026-01-12 04:09:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'lamplightdev-fix/tabgroup-mutation-observer' into next

Browse Source
This commit is contained in:
Cory LaViska
2020-08-02 06:47:05 -04:00
parent c1300ea3d6 92fdc551d8
commit 887bfb258b
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/components/tab-group/tab-group.tsx
View File

@@ -59,7 +59,15 @@ export class TabGroup {
focusVisible.observe(this.tabGroup);
// Update aria labels if the DOM changes
this.mutationObserver = new MutationObserver(() => setTimeout(() => this.setAriaLabels()));
this.mutationObserver = new MutationObserver(mutations => {
if (
mutations.some(mutation => {
return !['aria-labeledby', 'aria-controls'].includes(mutation.attributeName);
})
) {
setTimeout(() => this.setAriaLabels());
}
});
this.mutationObserver.observe(this.host, { attributes: true, childList: true, subtree: true });
}
@@ -133,7 +141,7 @@ export class TabGroup {
const panel = panels.find(el => el.name === tab.panel);
if (panel) {
tab.setAttribute('aria-controls', panel.getAttribute('id'));
panel.setAttribute('arial-labeledby', tab.getAttribute('id'));
panel.setAttribute('aria-labeledby', tab.getAttribute('id'));
}
});
}