1774 Commits

Author SHA1 Message Date
Matt McLean
bcf08a8e41 Carousel accessibility (#2364)
* Remove code that sets the carousel item role attribute.

* When pagination is active, set accessibility attributes on dots and slides.

* When slide is active, avoid including a 'Go to slide...' aria-label on the tab.

* Troubleshoot accessibility test for pagination

* Add exception for accessibility test.

* Prettier fix
2025-03-11 13:37:35 -04:00
Cory LaViska
d2ce98318b Merge branch 'fix/a11y-errors-for-blur' of https://github.com/schilchSICKAG/shoelace into schilchSICKAG-fix/a11y-errors-for-blur 2025-03-11 13:30:23 -04:00
Susanne Kirchner
e09277e98f Fixes closable sl-alert can be closed on whole vertical area without visual indication (#2375)
* Avoid stretching of the closable icon button

* Fix prettier
2025-03-11 13:27:55 -04:00
Diego Ferreiro Val
5ef3c9178c fix contextElement guard (#2399) 2025-03-11 13:24:53 -04:00
Gabriel Belgamo
91235cbb32 Fixes dropdown closing on tab key (#2371)
* fix(sl-menu): tabbing closes the dropdown when it's open

* fix(arbitrary content): tabbing closes the dropdown when it's open

* feat: add pr suggestions
2025-03-11 13:17:33 -04:00
Christian Schilling
0a48bc5ddc Merge remote-tracking branch 'upstream/next' into fix/a11y-errors-for-blur
# Conflicts:
#	docs/pages/resources/changelog.md
2025-03-03 07:33:10 +01:00
Christian Schilling
d83d620c27 Remove log statement 2025-03-03 07:26:58 +01:00
Christian Schilling
6f09a75567 Fix: Nested tab groups broken in v2.19.1 (#2367)
* Fix for #2320

* Add Changelog pr#

* Use correct attribute filter
2025-02-28 10:30:58 -05:00
Christian Schilling
19537b145d Fix a11y issues for closing components with focused children 2025-02-21 08:02:27 +01:00
Cory LaViska
ff34da169e prettier 2025-02-03 16:24:32 -05:00
Auri Collings
a7aadc93f9 SlSplitPanel snap improvements. (#2340)
* (sl-split-panel) Add repeat expression and function expression to [snap].

* (sl-split-panel) Improve documentation.

* Improve split panel repeat() syntax, code cleanup.
- Move helper methods for split panel (toSnapFunction), and type definitions (SnapFunction, SnapFunctionParams) to split-panel.component.ts
- Allow repeat() to exist within other snap points in the split panel snap property. e.g. "repeat(100px) 50% 70% 90px" is now valid.

* Apply suggestions from code review

Co-authored-by: Cory LaViska <cory@abeautifulsite.net>

---------

Co-authored-by: Cory LaViska <cory@abeautifulsite.net>
2025-02-03 16:14:00 -05:00
Christian Schilling
372ba1f66d fix ssr for sl-alert and scrollend-polyfill (#2359)
* Fix: Make Alert SSR compatible

* Fix: Make sure polyfill is only called on the frontend

* Add changelog entries

* Removed debug statement

* Changelog adjustments

* Another console.log statement :(

---------

Co-authored-by: Cory LaViska <cory@abeautifulsite.net>
2025-02-03 14:26:54 -05:00
Konnor Rogers
b0399ca74e fix tabbable for radios (#2357)
* fix tabbable for radios

* prettier

* add note about focus trapping

* prettier
2025-02-03 14:20:27 -05:00
Susanne Kirchner
81e94f2624 Only trigger defaultslotchange of select after initialization (#2318) 2025-01-02 09:59:18 -05:00
jz5
7fd18d1abc Modify ja.ts (#2329) 2025-01-02 09:29:54 -05:00
Cory LaViska
f7b7ab95f8 sigh 2024-12-04 13:44:06 -05:00
Cory LaViska
e5d602ec48 prettier 2024-12-04 13:03:05 -05:00
Cory LaViska
5d0c877a05 fix conflict 2024-12-04 13:00:57 -05:00
Patrick McDougle
97fcab8f2a Fix rendering performance bottleneck in carousel (#2281)
* Fix rendering performance bottleneck in carousel

* Remove check before using RAF

* Optimistically mark the slide change as pending until the rAF callback runs
2024-12-04 12:49:19 -05:00
Susanne Kirchner
5267aa9b46 Update active tab if the "active" property on a sl-tab changes (#2299) 2024-12-04 12:19:18 -05:00
Patrick McDougle
077bff7832 Fix Race Condition if goToSlide is called too early 2024-12-02 14:55:57 -06:00
Cory LaViska
0c8348dc70 update dependencies 2024-12-02 13:44:53 -05:00
Evan Harrison
addac51b5f Fix sl-select padding issue with multiple and placeholder options combined (#2292)
* fix missing padding on sl-select placeholder with multiple option and medium or large size

* fix icon prefix padding issue on sl-select - do not apply margin to the select prefix when placeholder is present
2024-12-02 13:33:06 -05:00
Emanuele Mastaglia
a764672d03 Fix/memory leak popup (#2274)
* fix(popup): start positioner only if active

* test(popup): add test for positioning behavior on active state change

* fix(popup): ensure positioner starts only when active and anchor is present
2024-12-02 13:25:54 -05:00
Konnor Rogers
a8900fd56c fix select regressions (#2255)
* fix select regressions

* prettier

* prettier

* fix value not clearing with clear / tag removal

* prettier

* prettier

* prettier

* prettier

* add changelog entry

* prettier

---------

Co-authored-by: Cory LaViska <cory@abeautifulsite.net>
2024-12-02 13:22:31 -05:00
Konnor Rogers
5fa62bc5bf Fix improper tag references in sl-select (#2287)
* fix improper tag references in sl-select

* update changelog

* prettier

* remove cem

* update changelog

* update changelog
2024-11-26 16:28:14 -05:00
Cory LaViska
8cbd07b401 prettier / changelog 2024-11-15 13:50:20 -05:00
Volodymyr Lisivka
604526f465 Ukrainian translation for shoelace (#2270)
* Ukrainian translation is added.

* Update message with numerals in uk.ts
2024-11-15 13:49:12 -05:00
Cory LaViska
c232214445 fix tabindex when readonly; fixes #2271 (#2272) 2024-11-15 12:12:54 -05:00
Alessandro
51473c608e fix(carousel): out of order slides when inside sl-resize-observer (#2260)
* fix: sync slides after complete initialization

* chore: leftover
2024-11-12 11:07:05 -05:00
Cory LaViska
3178dc6278 prettier 2024-11-12 11:05:59 -05:00
Anders Engan
4580c5bc7c Adds Norwegian translations (#2268)
* Add translations for norwegian bokmål

* Add translations for norwegian nynorsk
2024-11-12 11:03:01 -05:00
Cory LaViska
8db6580987 prevent clicks while dragging; fixes #2196 (#2259) 2024-11-05 11:43:32 -05:00
Enrico Gruner
569acdb7c9 fix possibly leaking eventlisteners (#2257) 2024-11-04 15:51:19 -05:00
Cory LaViska
9919e435bb wait longer for CI 2024-11-01 12:58:12 -04:00
Cory LaViska
73c469ff45 Styles fixes (#2238)
* fix invalid rule

* fixes #2107
2024-10-28 14:05:32 -04:00
Cory LaViska
fa716029a7 fix test 2024-10-28 13:55:38 -04:00
Cory LaViska
80c3d8784b improve range/tooltip perf; fixes #2064 (#2237) 2024-10-28 13:39:12 -04:00
Cory LaViska
aca0f3d64a update option label on change; fixes #1971 (#2236) 2024-10-28 13:02:57 -04:00
Joshua Brink
2e73b3d6c5 fix property naming (#2233) 2024-10-28 12:52:05 -04:00
Cory LaViska
8737d6cb33 fix directionality check (#2235) 2024-10-28 11:39:16 -04:00
Cory LaViska
86a3e89761 align enter key with aria apg window splitter (#2234) 2024-10-28 10:45:05 -04:00
Alessandro
ae30d40e62 poc: more responsive carousel pagination dots (#2220)
* chore(carousel): more responsive dots

* chore: minor change

* chore: update

* chore: update

* chore: minor change
2024-10-24 16:25:14 -04:00
dhellgartner
bb7e840fac Issue 2117: Fix sl-select throws exception if a sl-input in the same form receives a new value with autofill in MS Edge (#2221)
* Issue 2117: Created a test to reproduce the issue

Note: Test is currently fainling before the actual fix

* Issue 2117: Check for the existenc of the key

* Bug is caused by an incorrect event triggered by Edge
* The event is missing the key property
* To fix the bug, check for the existence of the property
before checking the length property

* Issue 2117: Reset delay in test

---------

Co-authored-by: Dominikus Hellgartner <dominikus.hellgartner@gmail.com>
2024-10-24 16:22:47 -04:00
Daniel Liebner
8ca1fc7749 SlTooltip call super.disconnectedCallback() (#2226) 2024-10-23 16:04:31 -04:00
Susanne Kirchner
b14498822b sl-tab-group throws error if unmounted too fast (#2218)
* Add check for undefined element on disconnect

* Fix prettier error
2024-10-16 10:53:11 -04:00
Cory LaViska
2c66c859d6 More resilient directionality checks (#2189)
* more resilient directionality checks; fixes #2188

* update check

* prettier

---------

Co-authored-by: Konnor Rogers <konnor5456@gmail.com>
2024-10-10 14:05:56 -04:00
Christian Schilling
5a3d46ae00 Add ability to focus sl-radio-group dynamically (#2192)
* Add ability to focus sl-radio-group dynamically

* Adjusted to review findings

* add changelog entry

* prettier

* add extra timeout for safari

* prettier

---------

Co-authored-by: konnorrogers <konnor5456@gmail.com>
2024-10-10 14:00:14 -04:00
Konnor Rogers
4f78930e99 add more resilient lazy loading to sl-select (#2204)
* add more resilient lazy loading to sl-select

* prettier

* add more resilient lazy loading to sl-select

* remove unnecessary assertions

* remove unnecessary assertions

* fix bad logic

* prettier

* add changelog entry

* prettier
2024-10-10 13:40:15 -04:00
Jouni Männistö
8806672459 Added Finnish translations. (#2211)
* Added Finnish translations.

* add changelog entry

* prettier

---------

Co-authored-by: konnorrogers <konnor5456@gmail.com>
2024-10-10 13:14:03 -04:00